downloadablefilesource: don't download files if they are already cached#1813
Closed
abderrahim wants to merge 1 commit into
Closed
downloadablefilesource: don't download files if they are already cached#1813abderrahim wants to merge 1 commit into
abderrahim wants to merge 1 commit into
Conversation
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
juergbi
approved these changes
Jan 22, 2023
Contributor
Author
|
This breaks in practice because pickling exceptions thrown in a blocking_activity doesn't work. So this actually depends on #1814 (or a similar solution) |
Contributor
|
These changes are incorporated in #1814 already, closing. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.